Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra buildInputs needed to use nix-shell on mac. #21878

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Add extra buildInputs needed to use nix-shell on mac. #21878

merged 1 commit into from
Feb 1, 2025

Conversation

trhodeos
Copy link
Contributor

Fixes #21398.

There were a couple other needed to get this working. I just iteratively added these as I encountered them.

@cburroughs cburroughs requested a review from benjyw January 28, 2025 17:15
@cburroughs
Copy link
Contributor

@trhodeos I've approved this for CI. Please add a brief item to the release notes per https://www.pantsbuild.org/stable/docs/contributions#release-notes

@mberndt123 or @benjyw please take a quick look (based on git history)

@trhodeos
Copy link
Contributor Author

@trhodeos I've approved this for CI. Please add a brief item to the release notes per https://www.pantsbuild.org/stable/docs/contributions#release-notes

Ah, I can't seem to add labels, but I feel like this warrants a release-notes:not-required label. It's merely a change for the development lifecycle, not pants itself.

@cburroughs cburroughs added the release-notes:not-required PR doesn't require mention in release notes label Jan 28, 2025
benjyw
benjyw reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged the original file, I didn't author it, so my actual understanding of nix remains minimal. But this seems beneficial (and, at worst, harmless).

@mberndt123 any thoughts before we merge?

@benjyw benjyw merged commit 19efaeb into pantsbuild:main Feb 1, 2025
24 checks passed
@benjyw
Copy link
Contributor

benjyw commented Feb 1, 2025

Thanks @trhodeos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

Assignees
No one assigned
Labels
release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to build Pants in nix-shell on OS X
3 participants
@trhodeos @cburroughs @benjyw